alamb commented on code in PR #4326:
URL: https://github.com/apache/arrow-rs/pull/4326#discussion_r1213083225
##########
parquet/src/column/page.rs:
##########
@@ -265,9 +265,10 @@ impl PageWriteSpec {
/// Contains metadata for a page
#[derive(Clone)]
pub struct PageMetadata {
- /// The number of rows in this page
- pub num_rows: usize,
-
+ /// The number of rows within the page if known
+ pub num_rows: Option<usize>,
+ /// The number of levels within the page if known
+ pub num_levels: Option<usize>,
Review Comment:
I double checked the spec. This PR seems consistent to me ✅
https://github.com/apache/parquet-format/blob/c766945d90935ebcd4e03fee13aad2b6efcadce3/src/main/thrift/parquet.thrift#L563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
