tustvold commented on code in PR #4326:
URL: https://github.com/apache/arrow-rs/pull/4326#discussion_r1213093077
##########
parquet/src/column/page.rs:
##########
@@ -277,18 +278,27 @@ impl TryFrom<&PageHeader> for PageMetadata {
fn try_from(value: &PageHeader) -> std::result::Result<Self, Self::Error> {
match value.type_ {
- crate::format::PageType::DATA_PAGE => Ok(PageMetadata {
- num_rows: value.data_page_header.as_ref().unwrap().num_values
as usize,
- is_dict: false,
- }),
+ crate::format::PageType::DATA_PAGE => {
+ let header = value.data_page_header.as_ref().unwrap();
+ Ok(PageMetadata {
+ num_rows: None,
+ num_levels: Some(header.num_values as _),
Review Comment:
Yeah, this logic is encoded in
https://github.com/apache/arrow-rs/pull/4326/files/549124a6cfebe946710595230d5bc4e4126954fb#diff-0cda716759f051812703723d2134741edaec0252f46895392e9917cdf4209c50R317
We actually only care that the max_rep_level == 0, although a max_def_level
== 0 would imply this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
