rtpsw commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1213557505
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -668,13 +668,13 @@ class InputState {
static Result<std::unique_ptr<InputState>> Make(
size_t index, TolType tolerance, bool must_hash, bool may_rehash,
- KeyHasher* key_hasher, AsofJoinNode* node, ExecNode* output,
+ KeyHasher* key_hasher, AsofJoinNode* node, ExecNode* input,
Review Comment:
> This still looking confusing:
>
> BackpressureController takes `ExecNode* node, ExecNode* output` and this
one nows takes `AsofJoinNode* node, ExecNode* input` which is inconsistent
>
> Can we make this consistent between the two?
This is actually intended to make things clearer. The two places have a
different perspective of what is an input and what is an output (which likely
caused confusion in the first place). The `ExecNode` passed to `Make` is an
input of the as-of-join node while `PauseProducing` (and similarly
`ResumeProducing`) sees the as-of-join node as [an
output](https://github.com/apache/arrow/blob/3299d12efc91220237266bfa6f985f9eb37492f8/cpp/src/arrow/acero/exec_plan.h#L291)
of the `ExecNode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
