rtpsw commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1214316831
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1406,6 +1458,9 @@ void TestBackpressure(BatchesMaker maker, int
num_batches, int batch_size,
total_length += batch->num_rows();
}
ASSERT_EQ(static_cast<int64_t>(num_batches * batch_size), total_length);
+
+ ASSERT_GT(pause_count, 0);
Review Comment:
> Can we validate pause resume counter for all sources?
I added validation ...
> i.e the slow table should not have been paused, but the fast tables should?
... but this is not the actual behavior - instead only one fast source gets
paused and resumed - so this is what the recent commit validates. @westonpace,
is this behavior expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
