rtpsw commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1218255714
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -529,7 +529,7 @@ class KeyHasher {
size_t index_;
std::vector<col_index_t> indices_;
std::vector<KeyColumnMetadata> metadata_;
- const RecordBatch* batch_;
+ std::atomic<const RecordBatch*> batch_;
Review Comment:
It is queried from one thread but invalidated from another. We discussed
offline that this can be simplified so that the key hasher would only be used
from one thread, but this is (currently?) out of scope for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
