pitrou commented on code in PR #35750:
URL: https://github.com/apache/arrow/pull/35750#discussion_r1218591060
##########
cpp/src/arrow/compute/kernels/vector_selection_filter_internal.cc:
##########
@@ -161,39 +173,88 @@ class PrimitiveFilterImpl {
out_is_valid_ = out_arr->buffers[0]->mutable_data();
}
out_data_ = reinterpret_cast<T*>(out_arr->buffers[1]->mutable_data());
- out_offset_ = out_arr->offset;
out_length_ = out_arr->length;
+ DCHECK_EQ(out_arr->offset, 0);
out_position_ = 0;
}
- void ExecNonNull() {
- // Fast filter when values and filter are not null
- ::arrow::internal::VisitSetBitRunsVoid(
- filter_data_, filter_offset_, values_length_,
- [&](int64_t position, int64_t length) { WriteValueSegment(position,
length); });
+ void ExecREEFilter() {
+ if (filter_.child_data[1].null_count == 0 && values_null_count_ == 0) {
Review Comment:
That might be the case indeed, though computing the null count should be
extremely fast (it's a stream of popcount instructions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
