pitrou commented on code in PR #35750:
URL: https://github.com/apache/arrow/pull/35750#discussion_r1219041492


##########
cpp/src/arrow/compute/kernels/vector_selection_internal.cc:
##########
@@ -239,6 +309,43 @@ struct Selection {
       }
     };
 
+    if (is_ree_filter) {
+      Status status;

Review Comment:
   That's a good question. Ideally there should be no overhead returning a 
successful Status, but in practice there is (we try to measure it in 
`type_benchmark.cc`). I'll let you choose what is best here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to