tustvold commented on code in PR #4376:
URL: https://github.com/apache/arrow-rs/pull/4376#discussion_r1221403305
##########
parquet/src/arrow/record_reader/mod.rs:
##########
@@ -313,90 +231,29 @@ where
)
})?;
- self.records.pad_nulls(
- self.values_written,
+ self.values.pad_nulls(
+ self.num_values,
values_read,
levels_read,
def_levels.nulls().as_slice(),
);
}
- let values_read = max(levels_read, values_read);
- self.set_values_written(self.values_written + values_read);
- Ok(values_read)
- }
-
- /// Inspects the buffered repetition levels in the range
`self.num_values..self.values_written`
- /// and returns the number of "complete" records along with the
corresponding number of values
- ///
- /// If `end_of_column` is true it indicates that there are no further
values for this
- /// column chunk beyond what is currently in the buffers
- ///
- /// A "complete" record is one where the buffer contains a subsequent
repetition level of 0
- fn count_records(
Review Comment:
This logic is now moved into RepetitionLevelDecoderImpl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
