tustvold commented on code in PR #4376:
URL: https://github.com/apache/arrow-rs/pull/4376#discussion_r1223338467
##########
parquet/src/column/reader/decoder.rs:
##########
@@ -94,6 +105,22 @@ pub trait RepetitionLevelDecoder: ColumnLevelDecoder {
}
pub trait DefinitionLevelDecoder: ColumnLevelDecoder {
+ /// Read definition level data into `out[range]` returning the number of
levels read
+ ///
+ /// `range` is provided by the caller to allow for types such as
default-initialized `[T]`
+ /// that only track capacity and not length
+ ///
+ /// # Panics
+ ///
+ /// Implementations may panic if `range` overlaps with already written data
+ ///
+ // TODO: Should this return the number of nulls
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
