danepitkin commented on code in PR #35656:
URL: https://github.com/apache/arrow/pull/35656#discussion_r1223193903
##########
python/pyarrow/types.pxi:
##########
@@ -40,10 +42,20 @@ cdef dict _pandas_type_map = {
_Type_HALF_FLOAT: np.float16,
_Type_FLOAT: np.float32,
_Type_DOUBLE: np.float64,
- _Type_DATE32: np.dtype('datetime64[ns]'),
- _Type_DATE64: np.dtype('datetime64[ns]'),
- _Type_TIMESTAMP: np.dtype('datetime64[ns]'),
- _Type_DURATION: np.dtype('timedelta64[ns]'),
+ _Type_DATE32: np.dtype('datetime64[D]'),
Review Comment:
The current tests manipulate the types so test cases pass, but these were
the tests that originally were failling (the tests in there current state are a
bit of a mess right now, I need to go back and clean them up once the
implementation actually appears to work properly) :
```
FAILED
pyarrow/tests/parquet/test_dataset.py::test_write_to_dataset_with_partitions[True]
- AssertionError: Attributes of DataFrame.iloc[:, 4] (column name="date") are
different
FAILED
pyarrow/tests/parquet/test_dataset.py::test_write_to_dataset_with_partitions[False]
- AssertionError: Attributes of DataFrame.iloc[:, 4] (column name="date") are
different
FAILED
pyarrow/tests/parquet/test_dataset.py::test_write_to_dataset_with_partitions_and_schema[True]
- AssertionError: Attributes of DataFrame.iloc[:, 4] (column name="date") are
different
FAILED
pyarrow/tests/parquet/test_dataset.py::test_write_to_dataset_with_partitions_and_schema[False]
- AssertionError: Attributes of DataFrame.iloc[:, 4] (column name="date") are
different
FAILED
pyarrow/tests/parquet/test_dataset.py::test_write_to_dataset_with_partitions_and_index_name[True]
- AssertionError: Attributes of DataFrame.iloc[:, 4] (column name="date") are
different
FAILED
pyarrow/tests/parquet/test_dataset.py::test_write_to_dataset_with_partitions_and_index_name[False]
- AssertionError: Attributes of DataFrame.iloc[:, 4] (column name="date") are
different
FAILED
pyarrow/tests/parquet/test_dataset.py::test_write_to_dataset_no_partitions[True]
- AssertionError: Attributes of DataFrame.iloc[:, 3] (column name="date") are
different
FAILED
pyarrow/tests/parquet/test_dataset.py::test_write_to_dataset_no_partitions[False]
- AssertionError: Attributes of DataFrame.iloc[:, 3] (column name="date") are
different
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
