arthurpassos commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1223350657
##########
cpp/src/parquet/encoding.h:
##########
@@ -140,15 +143,37 @@ template <>
struct EncodingTraits<ByteArrayType> {
using Encoder = ByteArrayEncoder;
using Decoder = ByteArrayDecoder;
+ using BinaryBuilder = ::arrow::BinaryBuilder;
Review Comment:
We can infer it by using decltype, but is it really a good thing? Having
this alias in the trait seems simpler to me than having something ugly like:
`using BuilderType = typename
std::remove_pointer<decltype(EncodingTraits<BAT>::Accumulator::builder.get())>::type;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
