arthurpassos commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1219782437
##########
cpp/src/parquet/types.h:
##########
@@ -64,8 +64,12 @@ struct Type {
DOUBLE = 5,
BYTE_ARRAY = 6,
FIXED_LEN_BYTE_ARRAY = 7,
+
+ // This parquet type does not actually exist (AFAIK) and is used to
+ // create proper type traits
+ LARGE_BYTE_ARRAY = 8,
Review Comment:
It is not a small change for sure, I have spent ~2 days on that and didn't
get it working. Had to change tons of files and classes.
Did you get a chance to look at my proposal? It removes the
`parquet::type::LARGE_BYTE_ARRAY` as requested, but keeps it on `arrow` side.
No template boolean flag being passed around for classes that do not need it,
see:
https://github.com/apache/arrow/pull/35825/files#diff-45ce192620cd512791348a3fa7ad1cb67476f048ba35bc082f1c18a11a26c668R768.
It seems much simpler and somehow more accurate since the type actually
exists on `arrow` side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
