WillAyd commented on code in PR #758:
URL: https://github.com/apache/arrow-adbc/pull/758#discussion_r1224826681


##########
c/driver/postgresql/postgres_type.h:
##########
@@ -223,6 +223,14 @@ class PostgresType {
         NANOARROW_RETURN_NOT_OK(ArrowSchemaSetType(schema, 
NANOARROW_TYPE_BINARY));
         break;
 
+      case PostgresTypeId::kTimestamp:
+        // TODO: it's possible to set a precision in the type, but how do we 
get that

Review Comment:
   If you cared to see what `p` is for a given column I think it maps to 
`atttypmod` in pg_attribute, much like the length specifier of VARCHAR:
   
   https://www.postgresql.org/docs/current/catalog-pg-attribute.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to