lidavidm commented on code in PR #758:
URL: https://github.com/apache/arrow-adbc/pull/758#discussion_r1224945459
##########
c/driver/postgresql/postgres_copy_reader.h:
##########
@@ -635,6 +635,19 @@ static inline ArrowErrorCode MakeCopyFieldReader(const
PostgresType& pg_type,
default:
return ErrorCantConvert(error, pg_type, schema_view);
}
+
+ case NANOARROW_TYPE_TIMESTAMP:
+ switch (pg_type.type_id()) {
+ case PostgresTypeId::kTimestamp: {
+ // 2000-01-01 00:00:00.000000 in microseconds
Review Comment:
Yes, presumably the clients convert the value (like we do here), but the
value on the wire is different (I extracted this constant by looking at it in
the debugger, and if you take current HEAD you'll get back a binary array with
this value encoded in it!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
