js8544 commented on code in PR #36020:
URL: https://github.com/apache/arrow/pull/36020#discussion_r1225212144
##########
cpp/src/arrow/compute/kernels/base_arithmetic_internal.h:
##########
@@ -60,6 +60,11 @@ struct Add {
static enable_if_decimal_value<T> Call(KernelContext*, Arg0 left, Arg1
right, Status*) {
return left + right;
}
+
+ template <typename T>
+ static constexpr T Identity() {
Review Comment:
The term identity is from the mathematical notation monoid. For any
associative binary operation, identity is definded as Op(identity, x) = x for
all x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
