js8544 commented on code in PR #36020:
URL: https://github.com/apache/arrow/pull/36020#discussion_r1225212555
##########
cpp/src/arrow/compute/kernels/base_arithmetic_internal.h:
##########
@@ -605,6 +625,70 @@ struct Sign {
}
};
+struct Max {
+ template <typename T, typename Arg0, typename Arg1>
+ static constexpr enable_if_not_floating_value<T> Call(KernelContext*, Arg0
arg0,
+ Arg1 arg1, Status*) {
+ static_assert(std::is_same<T, Arg0>::value && std::is_same<Arg0,
Arg1>::value);
+ return std::max(arg0, arg1);
+ }
+
+ template <typename T, typename Arg0, typename Arg1>
+ static constexpr enable_if_floating_value<T> Call(KernelContext*, Arg0 left,
Arg1 right,
+ Status*) {
+ static_assert(std::is_same<T, Arg0>::value && std::is_same<Arg0,
Arg1>::value);
+ if (std::isnan(left)) {
Review Comment:
The handling of nan is to be consistent with compute functions
min_element_wise and max_element_wise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
