domoritz commented on code in PR #36032:
URL: https://github.com/apache/arrow/pull/36032#discussion_r1225871392
##########
js/src/util/buffer.ts:
##########
@@ -63,7 +63,7 @@ export function joinUint8Arrays(chunks: Uint8Array[], size?:
number | null): [Ui
// streaming, where we may be reading partial byte ranges out of the same
underlying ArrayBuffer
const result = collapseContiguousByteRanges(chunks);
const byteLength = result.reduce((x, b) => x + b.byteLength, 0);
- let source: Uint8Array, sliced: Uint8Array, buffer: Uint8Array | void;
+ let source: Uint8Array, sliced: Uint8Array, buffer: Uint8Array | undefined;
Review Comment:
Without this change, TS is not happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
