viirya commented on PR #6632: URL: https://github.com/apache/arrow-datafusion/pull/6632#issuecomment-1586347255
> After reviewing #6638 from @viirya I am not sure about this PR anymore -- it seems like this PR simply makes the signature match for the array versions but then it would be inconsistent with the scalar versions... > > I think any real fix should have the array and scalar implementations match and of course the signature match 🤔 Hmm, I think this should be correct. As I mentioned in https://github.com/apache/arrow-datafusion/pull/6632#discussion_r1225918413, actually the second argument (no matter scalar or array) should be `Timestamp(Nanosecond, None)` based on the function signature. Unless that we want to make date_trunc accepts all timestamp types instead of just nanosecond timestamp. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
