alamb commented on PR #6632:
URL:
https://github.com/apache/arrow-datafusion/pull/6632#issuecomment-1586352059
> Unless that we want to make date_trunc accepts all timestamp types instead
of just nanosecond timestamp, and returns same output type as input type.
Yeah, this is what I was thinking. This might have the benefit of supporting
larger timestamp ranges as `timestamp(second, ...)` can hold a larger range
But I suppose since we already have fixes lined up that standardize on
always generating `timestamp(nanosecond, None)` that seems better than what is
on master.
cc @waitingkuo in case you have some opinions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
