alamb opened a new pull request, #6671: URL: https://github.com/apache/arrow-datafusion/pull/6671
# Which issue does this PR close? Draft as it builds on https://github.com/apache/arrow-datafusion/pull/6669 Closes https://github.com/apache/arrow-datafusion/issues/6611 # Rationale for this change When used as window functions, `AggregateUDF` can not use the `retract_batch` API to speed up the calculations # What changes are included in this PR? 1. Add a new `supports_retract_batch` in `Accumulator` trait (to mirror the API added by @mustafasrepo for Window Functions) 2. If the Accumulator reports it supports retrict batch, use the sliding accumulator # Are these changes tested? Yes <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? New API, though they should all be backwards compatible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
