mustafasrepo commented on code in PR #6671:
URL: https://github.com/apache/arrow-datafusion/pull/6671#discussion_r1230509976
##########
datafusion/core/src/physical_plan/windows/mod.rs:
##########
@@ -90,12 +93,26 @@ pub fn create_window_expr(
order_by,
window_frame,
)),
- WindowFunction::AggregateUDF(fun) =>
Arc::new(PlainAggregateWindowExpr::new(
- udaf::create_aggregate_expr(fun.as_ref(), args, input_schema,
name)?,
- partition_by,
- order_by,
- window_frame,
- )),
+ WindowFunction::AggregateUDF(fun) => {
+ let aggregate =
+ udaf::create_aggregate_expr(fun.as_ref(), args, input_schema,
name)?;
+
+ if !unbounded_window && aggregate.retractable()? {
Review Comment:
I think this line should be
```suggestion
if !unbounded_window {
```
If aggregate doesn't implement retract we should get an error. There is no
way to run aggregator whose start is different than (`UNBOUNDED PRECEDING`)
without `retract_batch` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
