pitrou commented on a change in pull request #8937:
URL: https://github.com/apache/arrow/pull/8937#discussion_r544519106
##########
File path: cpp/src/arrow/util/hashing.h
##########
@@ -691,7 +691,7 @@ class BinaryMemoTable : public MemoTable {
const builder_offset_type* offsets = binary_builder_.offsets_data();
const builder_offset_type delta =
- start < binary_builder_.value_data_length() ? offsets[start] : 0;
+ start < binary_builder_.length() ? offsets[start] : 0;
Review comment:
Is `start >= binary_builder_.length()` possible though? And in that
case, should `delta` really be 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
