pitrou commented on a change in pull request #8937:
URL: https://github.com/apache/arrow/pull/8937#discussion_r544523627
##########
File path: cpp/src/arrow/util/hashing.h
##########
@@ -691,7 +691,7 @@ class BinaryMemoTable : public MemoTable {
const builder_offset_type* offsets = binary_builder_.offsets_data();
const builder_offset_type delta =
- start < binary_builder_.value_data_length() ? offsets[start] : 0;
+ start < binary_builder_.length() ? offsets[start] : 0;
Review comment:
I'd rather use the strict check. It's not obvious that `delta = 0` is
the right choice otherwise (since the table is non-empty).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
