bkietz commented on code in PR #36018:
URL: https://github.com/apache/arrow/pull/36018#discussion_r1231097520
##########
cpp/src/arrow/array/data.cc:
##########
@@ -228,11 +228,12 @@ void ArraySpan::SetMembers(const ArrayData& data) {
namespace {
template <typename offset_type>
-void SetOffsetsForScalar(ArraySpan* span, offset_type* buffer, int64_t
value_size,
+void SetOffsetsForScalar(ArraySpan* span, uint8_t* buffer, int64_t value_size,
Review Comment:
Yes, but we always initialize value_size from `ArrayData::length` or
`Buffer::length()`, which are both `int64_t`- so we'd still need the
`static_cast<offset_type>` but it'd be at each call site to
SetOffsetsForScalar. We would be able to call it without the explicit
offset_type template argument, so that'd be a bit nicer
If you think that's preferable, I'll do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
