bkietz commented on code in PR #36018:
URL: https://github.com/apache/arrow/pull/36018#discussion_r1231375261
##########
cpp/src/arrow/scalar.h:
##########
@@ -111,6 +111,12 @@ struct ARROW_EXPORT Scalar : public
std::enable_shared_from_this<Scalar>,
protected:
Scalar(std::shared_ptr<DataType> type, bool is_valid)
: type(std::move(type)), is_valid(is_valid) {}
+
+ // 16 bytes of scratch space to enable ArraySpan to be a view onto any
+ // Scalar- including binary scalars where we need to create a buffer
+ // that looks like two 32-bit or 64-bit offsets.
+ alignas(int64_t) std::array<uint8_t, sizeof(int64_t) * 2> scratch_space_{0};
Review Comment:
I'll use the c array, then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]