arthurpassos commented on PR #35825:
URL: https://github.com/apache/arrow/pull/35825#issuecomment-1593497814
> I think `TransferBinary` has comment below:
>
> ```c++
> for (auto& chunk : chunks) {
> if (!chunk->type()->Equals(*logical_type_field->type())) {
> // XXX: if a LargeBinary chunk is larger than 2GB, the MSBs of
offsets
> // will be lost because they are first created as int32 and then
cast to int64.
> ARROW_ASSIGN_OR_RAISE(
> chunk,
> ::arrow::compute::Cast(*chunk, logical_type_field->type(),
cast_options, &ctx));
> }
> }
> ```
>
> I guess comment should be changed like `if a LargeBinary chunk is larger
than 2GB, and not have set use_large_binary_variants`.
>
> It's a bit late in utc-8, I'll review it carefully tomorrow.
Updated the comment. Thanks for looking into this, have a nice one over
there :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
