arthurpassos commented on PR #35825:
URL: https://github.com/apache/arrow/pull/35825#issuecomment-1594705401

   > * Read both overflow and non-overflow cases with 
`use_large_binary_variant` = true.
   
   I have made a few local changes to propagate `ArrowReaderProperties` through 
`ParquetIOTestBase::RoundTripSingleColumn` on `TEST_F(TestLargeBinaryParquetIO, 
Basics)`. During read, it successfully determines it has to pick the LARGE* 
variants. The problem is that during the write operation the default reader 
properties are used, see: 
https://github.com/apache/arrow/blob/main/cpp/src/parquet/arrow/writer.cc#L306. 
This causes the test to fail with:
   
   ```
   Failed
   # Array types differed: binary vs large_binary
   ```
   
   Should I change the write call stack as well to propagate the reader 
properties?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to