paleolimbot commented on code in PR #117:
URL: https://github.com/apache/arrow-nanoarrow/pull/117#discussion_r1231694016
##########
python/nanoarrow/_lib.pyx:
##########
@@ -730,9 +761,13 @@ cdef class ArrayViewBuffers:
cdef ArrayView _array_view
cdef int64_t _length
- def __init__(self, ArrayView array_view):
+ def __cinit__(self, ArrayView array_view):
self._array_view = array_view
- self._length = array_view._array._ptr.n_buffers
+ self._length = 3
Review Comment:
It's just to remove the reference to the `_array`, since that no longer
exists. The `ArrowArrayView` in C doesn't have an explicit `n_buffers` member
(but maybe should since the shenanigan on the following lines gets used quite a
bit in C as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
