paleolimbot commented on code in PR #117:
URL: https://github.com/apache/arrow-nanoarrow/pull/117#discussion_r1231694271
##########
python/nanoarrow/_lib.pyx:
##########
@@ -526,23 +546,28 @@ cdef class ArrayView:
@property
def dictionary(self):
- return ArrayView(self, <uintptr_t>self._ptr.dictionary,
self._array.dictionary)
-
- @property
- def array(self):
- return self._array
+ if self._ptr.dictionary == NULL:
+ return None
+ else:
+ return ArrayView(
+ self,
+ <uintptr_t>self._ptr.dictionary,
+ self._schema.dictionary,
+ None
Review Comment:
The buffer shelter is None here because the child/dictionary's reference to
`self` is sufficient to keep the buffers valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
