pitrou commented on code in PR #35628:
URL: https://github.com/apache/arrow/pull/35628#discussion_r1234262985
##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -710,6 +710,15 @@ struct ScalarToProtoImpl {
s);
}
+ Status Visit(const StringViewScalar& s) {
Review Comment:
Substrait changes can probably left for another PR (I suppose you'll need to
write tests for them?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
