pitrou commented on code in PR #35628:
URL: https://github.com/apache/arrow/pull/35628#discussion_r1234263947
##########
cpp/src/arrow/compute/kernel.cc:
##########
@@ -249,9 +249,35 @@ class LargeBinaryLikeMatcher : public TypeMatcher {
std::string ToString() const override { return "large-binary-like"; }
};
+std::shared_ptr<TypeMatcher> LargeBinaryLike() {
+ return std::make_shared<LargeBinaryLikeMatcher>();
+}
+
+class BinaryViewLikeMatcher : public TypeMatcher {
Review Comment:
Most compute changes do not belong in this PR IMHO (except perhaps for
casting, if required).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
