icexelloss commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1235360574
##########
cpp/src/arrow/acero/exec_plan.cc:
##########
@@ -951,7 +951,6 @@ struct BatchConverter {
if (exec_plan->finished().is_finished()) {
return;
}
- exec_plan->StopProducing();
Review Comment:
I am not sure about this. It's not clear to me what's the intent of calling
StopProducing here in the first place. And `reader->Close()` isn't called in
all cases so I think it is safer to leave this unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]