icexelloss commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1235769930
##########
cpp/src/arrow/acero/exec_plan.cc:
##########
@@ -1001,18 +1000,24 @@ struct BatchConverter {
Result<AsyncGenerator<std::shared_ptr<RecordBatch>>>
DeclarationToRecordBatchGenerator(
Declaration declaration, QueryOptions options,
- ::arrow::internal::Executor* cpu_executor, std::shared_ptr<Schema>*
out_schema) {
+ ::arrow::internal::Executor* cpu_executor, std::shared_ptr<Schema>*
out_schema,
+ std::shared_ptr<ExecPlan>* out_plan) {
Review Comment:
I think it is worthwhile to at least explain that the `out_plan` is used for
cancellation, otherwise this API looks confusion - it is not intuitive to
return exec plan in a method called DeclarationToRecordBatchGenerator)?
##########
cpp/src/arrow/acero/exec_plan.cc:
##########
@@ -1001,18 +1000,24 @@ struct BatchConverter {
Result<AsyncGenerator<std::shared_ptr<RecordBatch>>>
DeclarationToRecordBatchGenerator(
Declaration declaration, QueryOptions options,
- ::arrow::internal::Executor* cpu_executor, std::shared_ptr<Schema>*
out_schema) {
+ ::arrow::internal::Executor* cpu_executor, std::shared_ptr<Schema>*
out_schema,
+ std::shared_ptr<ExecPlan>* out_plan) {
Review Comment:
I think it is worthwhile to at least explain that the `out_plan` is used for
cancellation, otherwise this API looks confusion - it is not intuitive to
return exec plan in a method called DeclarationToRecordBatchGenerator)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
