zeroshade commented on code in PR #36142:
URL: https://github.com/apache/arrow/pull/36142#discussion_r1235733398
##########
go/arrow/csv/reader.go:
##########
@@ -475,10 +490,26 @@ func (r *Reader) initFieldConverter(bldr array.Builder)
func(string) {
return func(s string) {
r.parseList(bldr, s)
}
+ case *arrow.LargeListType:
+ return func(s string) {
+ r.parseLargeList(bldr, s)
+ }
+ case *arrow.FixedSizeListType:
+ return func(s string) {
+ r.parseFixedSizeList(bldr, s, int(dt.Len()))
+ }
case *arrow.BinaryType:
return func(s string) {
r.parseBinaryType(bldr, s)
}
+ case *arrow.LargeBinaryType:
+ return func(s string) {
+ r.parseLargeBinaryType(bldr, s)
+ }
+ case *arrow.FixedSizeBinaryType:
+ return func(s string) {
+ r.parseFixedSizeBinaryType(bldr, s, dt.BitWidth())
Review Comment:
use `dt.Bytes()` instead, so you don't need to do the `8*` in the parsing
function since it will return the number of bytes directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
