zeroshade commented on code in PR #36142:
URL: https://github.com/apache/arrow/pull/36142#discussion_r1237375054


##########
go/arrow/csv/reader.go:
##########
@@ -884,7 +884,7 @@ func (r *Reader) parseBinaryType(field array.Builder, str 
string) {
        }
        decodedVal, err := base64.StdEncoding.DecodeString(str)
        if err != nil {
-               panic("cannot decode base64 string " + str)
+               r.err = fmt.Errorf("cannot decode base64 string %s", str)

Review Comment:
   should probably AppendNull instead of appending the value anyways after 
getting this error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to