comphead commented on code in PR #6722:
URL: https://github.com/apache/arrow-datafusion/pull/6722#discussion_r1237126907
##########
datafusion/core/src/datasource/mod.rs:
##########
@@ -199,3 +200,24 @@ fn get_col_stats(
})
.collect()
}
+
+fn schema_eq_ignore_nullable(
Review Comment:
@jonahgao That is true and depending on use and what schema is driving. I
tested SqlLogic engine which currently uses `.contains` and found that
this query will fail
```
query I
select null a union all select 1 a;
----
```
and this does not
```query II
select 1 a union all select null a;
----
```
Depending on driving schema
Please try if `.contains` will work for you, if its not, we need to create a
dedicated method similar to @alamb suggestion
https://docs.rs/datafusion-common/26.0.0/datafusion_common/struct.DFSchema.html#method.equivalent_names_and_types
but for `Schema`
If you create the method so I can also fix a hidden bug in sql logic test
engine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
