jonahgao commented on code in PR #6722:
URL: https://github.com/apache/arrow-datafusion/pull/6722#discussion_r1240838739
##########
datafusion/common/src/dfschema.rs:
##########
@@ -729,6 +729,34 @@ impl From<Field> for DFField {
}
}
+/// DataFusion-specific extensions to [`Schema`].
+pub trait SchemaExt {
+ /// This is a specialized version of Eq that ignores differences
+ /// in nullability and metadata.
+ ///
+ /// It works the same as [`DFSchema::equivalent_names_and_types`].
+ fn equivalent_names_and_types(&self, other: &Self) -> bool;
+}
+
+impl SchemaExt for Schema {
+ fn equivalent_names_and_types(&self, other: &Self) -> bool {
+ if self.fields().len() != other.fields().len() {
+ return false;
+ }
+
+ self.fields()
+ .iter()
+ .zip(other.fields().iter())
+ .all(|(f1, f2)| {
+ f1.name() == f2.name()
+ && DFSchema::datatype_is_semantically_equal(
Review Comment:
I think this might be more convenient to use 🤔 .
All the test cases from DFSchema have been reused for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
