arthurpassos commented on PR #35825: URL: https://github.com/apache/arrow/pull/35825#issuecomment-1601317375
> ``` > FAILED: CMakeFiles/lint > cd /tmp/arrow-lint-nb33lpih/cpp-build && /usr/local/bin/python /arrow/cpp/build-support/run_cpplint.py --cpplint_binary /arrow/cpp/build-support/cpplint.py --exclude_globs /arrow/cpp/build-support/lint_exclusions.txt --source_dir /arrow/cpp/src --source_dir /arrow/cpp/examples --source_dir /arrow/cpp/tools --quiet > /arrow/cpp/src/parquet/encoding.cc:1635: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/encoding.cc:1638: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/encoding.cc:1639: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/encoding.cc:1665: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/encoding.cc:1668: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/encoding.cc:1669: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/encoding.cc:3612: Lines should be <= 90 characters long [whitespace/line_length] [2] > Done processing /arrow/cpp/src/parquet/encoding.cc > Total errors found: 7 > > /arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:441: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:629: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:678: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:728: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:730: Lines should be <= 90 characters long [whitespace/line_length] [2] > /arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:1438: Lines should be <= 90 characters long [whitespace/line_length] [2] > Done processing /arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc > Total errors found: 6 > > /arrow/cpp/src/parquet/arrow/schema.cc:466: Lines should be <= 90 characters long [whitespace/line_length] [2] > Done processing /arrow/cpp/src/parquet/arrow/schema.cc > Total errors found: 1 > > ninja: build stopped: subcommand failed. > ``` > > I guess you need to format the code. I'll take a detail review tomorrow I have just executed the below command and pushed its changes, hope it fixes this: git diff --name-only e5e96ec60184968fb3b7a571f258083895f2717f..232e01fdd2e479ed6a2f42fc318eb6a82a0248d5 | xargs clang-format -i -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
