pitrou commented on code in PR #36231:
URL: https://github.com/apache/arrow/pull/36231#discussion_r1238394688
##########
cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc:
##########
@@ -1152,6 +1152,53 @@ TEST(TestBinaryArithmetic,
AddWithImplicitCastsUint64EdgeCase) {
ArrayFromJSON(uint64(),
"[18446744073709551615]")}));
}
+TEST(TestBinaryArithmetic, MultiplyDuration) {
Review Comment:
We already have `TestTemporalMultiplyDuration` in `scalar_temporal_test.cc`,
can you augment that test instead?
Also, notice `TestTemporalDivideDuration` which hints that the same
improvement could be done for division...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
