bkietz commented on code in PR #36231:
URL: https://github.com/apache/arrow/pull/36231#discussion_r1239969698
##########
cpp/src/arrow/compute/kernels/scalar_arithmetic.cc:
##########
@@ -616,6 +617,21 @@ ArrayKernelExec
GenerateArithmeticWithFixedIntOutType(detail::GetTypeId get_id)
}
}
+void PromoteIntegerForDurationArithmetic(std::vector<TypeHolder>* types) {
+ bool has_duration = std::any_of(types->begin(), types->end(), [](const
TypeHolder& t) {
Review Comment:
:rocket:
##########
cpp/src/arrow/compute/kernels/scalar_arithmetic.cc:
##########
@@ -616,6 +617,21 @@ ArrayKernelExec
GenerateArithmeticWithFixedIntOutType(detail::GetTypeId get_id)
}
}
+void PromoteIntegerForDurationArithmetic(std::vector<TypeHolder>* types) {
Review Comment:
Please declare this in `codegen_internal.h` next to the other DispatchBest
helpers for findability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
