pitrou commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1238510486
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -438,11 +438,13 @@ void CheckConfiguredRoundtrip(
void DoSimpleRoundtrip(const std::shared_ptr<Table>& table, bool use_threads,
int64_t row_group_size, const std::vector<int>&
column_subset,
std::shared_ptr<Table>* out,
- const std::shared_ptr<ArrowWriterProperties>&
arrow_properties =
- default_arrow_writer_properties()) {
+ const std::shared_ptr<ArrowWriterProperties>&
+ arrow_writer_properties =
default_arrow_writer_properties(),
+ const ArrowReaderProperties& arrow_reader_properties =
+ default_arrow_reader_properties()) {
Review Comment:
This new parameter doesn't seem used anywhere below? Why add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
