pitrou commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1238520794


##########
cpp/src/parquet/properties.h:
##########
@@ -851,6 +852,12 @@ class PARQUET_EXPORT ArrowReaderProperties {
     return coerce_int96_timestamp_unit_;
   }
 
+  void set_use_large_binary_variants(bool use_large_binary_variants) {

Review Comment:
   There should be docstrings here.
   
   Also, it's a pity we can't easily configure this per-column, as this is 
going to be wasteful for files with many columns...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to