pitrou commented on code in PR #765:
URL: https://github.com/apache/arrow-adbc/pull/765#discussion_r1238602761
##########
adbc.h:
##########
@@ -1362,6 +1743,72 @@ AdbcStatusCode AdbcConnectionGetTableSchema(struct
AdbcConnection* connection,
struct ArrowSchema* schema,
struct AdbcError* error);
+/// \brief Get statistics about the data distribution of table(s).
+///
+/// The result is an Arrow dataset with the following schema:
+///
+/// | Field Name | Field Type |
+/// |--------------------------|----------------------------------|
+/// | catalog_name | utf8 |
+/// | catalog_db_schemas | list<DB_SCHEMA_SCHEMA> |
+///
+/// DB_SCHEMA_SCHEMA is a Struct with fields:
+///
+/// | Field Name | Field Type |
+/// |--------------------------|----------------------------------|
+/// | db_schema_name | utf8 |
+/// | db_schema_functions | list<STATISTICS_SCHEMA> |
+///
+/// STATISTICS_SCHEMA is a Struct with fields:
+///
+/// | Field Name | Field Type | Comments |
+/// |--------------------------|----------------------------------| -------- |
+/// | table_name | utf8 not null | |
+/// | column_name | utf8 | (1) |
+/// | statistic_name | dictionary<int16, utf8> not null | (2) |
+/// | statistic_value | VALUE_SCHEMA not null | |
+/// | statistic_is_approximate | bool not null | (3) |
+///
+/// 1. If null, then the statistic applies to the entire table.
+/// 2. A dictionary-encoded statistic name. Values in [0, 1024) are
+/// reserved for ADBC use. Other values are free for
+/// implementation-specific statistics. For the names and
+/// definitions of predefined statistic types, see \ref
+/// adbc-table-statistics.
Review Comment:
Well, I think you want to make lookups easy as well. As is "I want the min
and max of column a.b.c".
##########
adbc.h:
##########
@@ -1362,6 +1743,72 @@ AdbcStatusCode AdbcConnectionGetTableSchema(struct
AdbcConnection* connection,
struct ArrowSchema* schema,
struct AdbcError* error);
+/// \brief Get statistics about the data distribution of table(s).
+///
+/// The result is an Arrow dataset with the following schema:
+///
+/// | Field Name | Field Type |
+/// |--------------------------|----------------------------------|
+/// | catalog_name | utf8 |
+/// | catalog_db_schemas | list<DB_SCHEMA_SCHEMA> |
+///
+/// DB_SCHEMA_SCHEMA is a Struct with fields:
+///
+/// | Field Name | Field Type |
+/// |--------------------------|----------------------------------|
+/// | db_schema_name | utf8 |
+/// | db_schema_functions | list<STATISTICS_SCHEMA> |
+///
+/// STATISTICS_SCHEMA is a Struct with fields:
+///
+/// | Field Name | Field Type | Comments |
+/// |--------------------------|----------------------------------| -------- |
+/// | table_name | utf8 not null | |
+/// | column_name | utf8 | (1) |
+/// | statistic_name | dictionary<int16, utf8> not null | (2) |
+/// | statistic_value | VALUE_SCHEMA not null | |
+/// | statistic_is_approximate | bool not null | (3) |
+///
+/// 1. If null, then the statistic applies to the entire table.
+/// 2. A dictionary-encoded statistic name. Values in [0, 1024) are
+/// reserved for ADBC use. Other values are free for
+/// implementation-specific statistics. For the names and
+/// definitions of predefined statistic types, see \ref
+/// adbc-table-statistics.
Review Comment:
Well, I think you want to make lookups easy (and reasonably efficient?) as
well. As is "I want the min and max of column a.b.c".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
