pitrou commented on code in PR #765:
URL: https://github.com/apache/arrow-adbc/pull/765#discussion_r1238634043
##########
adbc.h:
##########
@@ -907,6 +1008,34 @@ AdbcStatusCode AdbcDatabaseNew(struct AdbcDatabase*
database, struct AdbcError*
AdbcStatusCode AdbcDatabaseGetOption(struct AdbcDatabase* database, const
char* key,
const char** value, struct AdbcError*
error);
+/// \brief Get a bytestring option of the database.
+///
+/// This must always be thread-safe (other operations are not).
Review Comment:
> Caller-allocated buffers get annoying because you have to somehow tell the
caller the size...
But at least the lifetime is safe.
##########
adbc.h:
##########
@@ -907,6 +1008,34 @@ AdbcStatusCode AdbcDatabaseNew(struct AdbcDatabase*
database, struct AdbcError*
AdbcStatusCode AdbcDatabaseGetOption(struct AdbcDatabase* database, const
char* key,
const char** value, struct AdbcError*
error);
+/// \brief Get a bytestring option of the database.
+///
+/// This must always be thread-safe (other operations are not).
Review Comment:
> Caller-allocated buffers get annoying because you have to somehow tell the
caller the size...
But at least the lifetime is safe and it makes things simpler for the
producer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
