pitrou commented on code in PR #36205: URL: https://github.com/apache/arrow/pull/36205#discussion_r1238789034
########## TODOs.txt: ########## @@ -0,0 +1,17 @@ +- Use a uniform API for all async Flight client APIs: + + void Foo(const FlightCallOptions&, shared_ptr<ReadListener<T>> listener); + + - shared_ptr, or raw pointer? (gRPC uses the latter...) + - How does this look for writes? + - Maybe we always call AddHold and RemoveHold? (It's unclear to me + why you'd want to read/write after the stream ends...) + +- StopToken needs to be able to run a callback, so that we can cancel gRPC calls. Review Comment: Yes, I think there's an issue already open for this? It should be doable now that we use a helper thread for signal-based cancellation. The main question is the API: do we want to ensure that callbacks are automatically removed at the end of a scope? Something else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
