lidavidm commented on code in PR #36205:
URL: https://github.com/apache/arrow/pull/36205#discussion_r1238789291
##########
cpp/src/arrow/flight/types.h:
##########
@@ -716,5 +720,130 @@ class ARROW_FLIGHT_EXPORT SimpleResultStream : public
ResultStream {
size_t position_;
};
+/// \defgroup flight-error Error Handling
+/// Types for handling errors from RPCs. Flight uses a set of status
+/// codes standardized across Flight implementations, so these types
+/// let applications work directly with those codes instead of having
+/// to translate to and from Arrow Status.
+
+/// \brief Abstract status code for an RPC as per the Flight
+/// specification.
Review Comment:
FlightStatusCode was a kludge in the original implementation to add to the
arrow::StatusCode list without modifying StatusCode. This was refactored out of
transport.h and intends to be definitive. (Both gRPC and UCX backends already
translate to it, then the synchronous API translates that into arrow::Status +
FlightStatusCode). I would rather make a clean break than try to repurpose or
extend FlightStatusCode (which also contains statuses that do not actually
exist in Flight on the wire.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
