lidavidm commented on code in PR #36205: URL: https://github.com/apache/arrow/pull/36205#discussion_r1238900376
########## TODOs.txt: ########## @@ -0,0 +1,17 @@ +- Use a uniform API for all async Flight client APIs: + + void Foo(const FlightCallOptions&, shared_ptr<ReadListener<T>> listener); + + - shared_ptr, or raw pointer? (gRPC uses the latter...) Review Comment: We could use non-const reference to express this more strongly? weak_ptr seems rather awkward to use here unless you already have a shared_ptr (in which case, you'd probably rather just pass shared_ptr), but I dislike forcing heap allocation here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
