joemarshall commented on code in PR #35672:
URL: https://github.com/apache/arrow/pull/35672#discussion_r1239675684
##########
cpp/src/arrow/util/thread_pool.h:
##########
@@ -393,8 +420,23 @@ class ARROW_EXPORT SerialExecutor : public Executor {
RunLoop();
return final_fut;
}
+
+#ifndef ARROW_ENABLE_THREADING
+ // we have to run tasks from all live executors
+ // during RunLoop if we don't have threading
+ static std::unordered_set<SerialExecutor*> all_executors;
Review Comment:
Because CPU processing can wait for i/o. And in theory (not sure but I think
in practice in acero) people can create multiple executors with dependencies
across each other, which should still work in this case, just with things in
other executors being run when one executor waits for the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
