joemarshall commented on code in PR #35672:
URL: https://github.com/apache/arrow/pull/35672#discussion_r1242334293
##########
cpp/src/arrow/util/future.cc:
##########
@@ -149,17 +150,39 @@ class ConcreteFutureImpl : public FutureImpl {
}
void DoWait() {
+#ifdef ARROW_ENABLE_THREADING
std::unique_lock<std::mutex> lock(mutex_);
cv_.wait(lock, [this] { return IsFutureFinished(state_); });
+#else
+ while (true) {
+ if (IsFutureFinished(state_)) {
+ return;
+ }
+ arrow::internal::SerialExecutor::RunTasksOnAllExecutors(true);
+ }
+#endif
}
bool DoWait(double seconds) {
+#ifdef ARROW_ENABLE_THREADING
std::unique_lock<std::mutex> lock(mutex_);
cv_.wait_for(lock, std::chrono::duration<double>(seconds),
[this] { return IsFutureFinished(state_); });
return IsFutureFinished(state_);
+#else
+ auto start = std::chrono::steady_clock::now();
+ std::chrono::duration<double> fsec =
std::chrono::duration<double>(seconds);
+ while (std::chrono::steady_clock::now() - start < fsec) {
+ // run one task then check time
+ if (IsFutureFinished(state_)) {
+ return true;
+ }
+ arrow::internal::SerialExecutor::RunTasksOnAllExecutors(true);
+ }
+ return IsFutureFinished(state_);
Review Comment:
I think this is the only time it turns up outside test specific code though.
I could pull it the equivalent (busywait) from gtest_util into threadpool or
somewhere instead, but I don't know if it is worth it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
