indigophox commented on code in PR #34817:
URL: https://github.com/apache/arrow/pull/34817#discussion_r1240464583
##########
cpp/src/arrow/flight/types.cc:
##########
@@ -430,6 +430,34 @@ std::string Location::scheme() const {
return scheme;
}
+std::string Location::path() const { return uri_->path(); }
+arrow::Result<std::vector<std::pair<std::string, std::string>>>
Location::query_items()
+ const {
+ return uri_->query_items();
+}
+
+arrow::Result<std::vector<std::pair<std::string, std::string>>>
Location::as_headers()
Review Comment:
(As elsewhere, probably dropping these to keep things clean and consistent.)
##########
cpp/src/arrow/flight/types.cc:
##########
@@ -430,6 +430,34 @@ std::string Location::scheme() const {
return scheme;
}
+std::string Location::path() const { return uri_->path(); }
+arrow::Result<std::vector<std::pair<std::string, std::string>>>
Location::query_items()
+ const {
+ return uri_->query_items();
+}
+
+arrow::Result<std::vector<std::pair<std::string, std::string>>>
Location::as_headers()
Review Comment:
(As elsewhere, we're planning on dropping these to keep things clean and
consistent.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
